Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring GalleryActivity to use Coroutine and ViewModel #4638

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Refactoring GalleryActivity to use Coroutine and ViewModel #4638

wants to merge 20 commits into from

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented May 2, 2024 •
edited

  • Use ViewModel and Coroutine in GalleryActivity and GalleryItemFragment
  • Remove unused source from GalleryActivity.
  • Update code structure to be consistent.

Bug: T303936

@cooltey cooltey added the WIP Work in progress label May 2, 2024
@cooltey cooltey added Ready to merge PR passed design signoff and ready to be merged. and removed WIP Work in progress labels May 3, 2024
Base automatically changed from coroutine-leadimageshandler to main May 4, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

@sharvaniharan sharvaniharan Awaiting requested review from sharvaniharan

Assignees
No one assigned
Labels
Ready to merge PR passed design signoff and ready to be merged.
Milestone
No milestone
2 participants
@cooltey @dbrant