Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do no parse -- and subsequent arguments on the command line #558

Conversation

maartenbreddels
Copy link
Contributor

This allows a user to pass custom args that can be parsed in the
application.

click does not seem to support this:
pallets/click#619

But it is easy to work around by passing the args ourselves after
removing the -- and subsequent args.

@maartenbreddels maartenbreddels marked this pull request as ready for review March 14, 2024 14:26
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maartenbreddels and the rest of your teammates on Graphite Graphite

@kdheepak
Copy link

I just tested it and it works great!

This allows a user to pass custom args that can be parsed in the
application.

click does not seem to support this:
pallets/click#619

But it is easy to work around by passing the args ourselves after
removing the -- and subsequent args.
@maartenbreddels maartenbreddels force-pushed the 03-14-fix_do_no_parse_--_and_subsequent_arguments_on_the_command_line branch from 94de306 to 5bab385 Compare March 18, 2024 12:50
@maartenbreddels maartenbreddels merged commit e3ea88a into master Mar 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants