fix: use the Route.component for the real component #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maartenbreddels and the rest of your teammates on |
maartenbreddels
force-pushed
the
03-13-fix_use_the_Route.component_for_the_real_component
branch
from
8b7e7fd
to
bd64bac
Compare
maartenbreddels
force-pushed
the
03-13-fix_layout_when_using_routes
branch
from
e3a2107
to
df40333
Compare
maartenbreddels
force-pushed
the
03-13-fix_use_the_Route.component_for_the_real_component
branch
from
bd64bac
to
5005994
Compare
Merge activity
|
maartenbreddels
changed the base branch from
03-13-fix_layout_when_using_routes
to
master
Before we put the internal RenderPage component in the Route.component. This was not only confusing, but also left no room for using this field for other purposes, such as using this for a custom Markdown component.
maartenbreddels
force-pushed
the
03-13-fix_use_the_Route.component_for_the_real_component
branch
from
5005994
to
dc8a62e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we put the internal RenderPage component in the Route.component.
This was not only confusing, but also left no room for using this
field for other purposes, such as using this for a custom Markdown
component.