feat: check for key mutation when removing children #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
iisakkirotko
force-pushed
the
04-17-fix__remove_element_failing_silently_when_child_objects_left_over
branch
from
e49f97c
to
173e73e
Compare
iisakkirotko
force-pushed
the
04-17-feat_check_for_key_mutation_when_removing_children
branch
from
9c92ae2
to
8d1dc5e
Compare
iisakkirotko
force-pushed
the
04-17-feat_check_for_key_mutation_when_removing_children
branch
2 times, most recently
from
56e37b7
to
be8f548
Compare
maartenbreddels
requested changes
Apr 25, 2024
iisakkirotko
force-pushed
the
04-17-feat_check_for_key_mutation_when_removing_children
branch
from
842d58b
to
6d9fcbd
Compare
iisakkirotko
force-pushed
the
04-17-fix__remove_element_failing_silently_when_child_objects_left_over
branch
from
173e73e
to
c645d15
Compare
iisakkirotko
force-pushed
the
04-17-feat_check_for_key_mutation_when_removing_children
branch
from
6d9fcbd
to
60f1c3e
Compare
maartenbreddels
approved these changes
Apr 26, 2024
Merge activity
|
iisakkirotko
changed the base branch from
04-17-fix__remove_element_failing_silently_when_child_objects_left_over
to
master
feat: test for error when key mutation is attempted
Co-authored-by: Maarten Breddels <maartenbreddels@gmail.com>
iisakkirotko
force-pushed
the
04-17-feat_check_for_key_mutation_when_removing_children
branch
from
60f1c3e
to
c782f05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.