add state/rds-aurora-serverless-v2-postgres.yaml #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab77
force-pushed
the
ab77/aurora-serverless-v2-postgres
branch
2 times, most recently
from
370bdfe
to
c0cff45
Compare
|
Hi @ab77 Do you consider this PR "done" or is it work in progress? |
@michaelwittig with the addition of |
ab77
force-pushed
the
ab77/aurora-serverless-v2-postgres
branch
from
c0cff45
to
20d22ca
Compare
ab77
force-pushed
the
ab77/aurora-serverless-v2-postgres
branch
from
20d22ca
to
f1b3426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Override all values in parentheses)
(Run
yamllint folder/template.yaml,cfn-lint -i E1019 E3002 E2520 -t folder/template.yaml, andaws cloudformation validate-template --template-body file://folder/template.yamlbefore you open a PR)(Do not include multiple changes in one PR. Open additional PRs instead.)
This the Aurora Serverless v2 PostgreSQL template, based off your v1, but with some additional useful features we typically use in production (e.g. exports, metrics and custom param. groups). I considered updating v1 with additional conditionals to make a "v2 toggle", but ended up settling on a separate template. I deployed this in a test environment with and without snapshot, so at least it deploys and creates a small v2 cluster. Let me know your thoughts..
P.S. I didn't end up using the built-in managed user/pass secrets (i.e. ManageMasterUserPassword and MasterUserSecret) since you already have a separate stack for that.