Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segmented ranking metrics #1514

Merged
merged 7 commits into from May 7, 2024
Merged

segmented ranking metrics #1514

merged 7 commits into from May 7, 2024

Conversation

richard-rogers
Copy link
Contributor

Description

Support segmented ranking metrics.

Changes

  • Segmented schemas are respected by the ranking metrics
  • Added sum_gain_k to unit tests

Closes #1506

FelipeAdachi
FelipeAdachi previously approved these changes May 7, 2024
Copy link
Contributor

@FelipeAdachi FelipeAdachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jamie256 and others added 2 commits May 7, 2024 13:34
Co-authored-by: richard-rogers <93153899+richard-rogers@users.noreply.github.com>
Co-authored-by: richard-rogers <93153899+richard-rogers@users.noreply.github.com>
jamie256
jamie256 previously approved these changes May 7, 2024
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamie256 jamie256 enabled auto-merge (squash) May 7, 2024 20:38
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamie256 jamie256 merged commit 6b42a36 into mainline May 7, 2024
19 checks passed
@jamie256 jamie256 deleted the dev/richard/1506 branch May 7, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ranking Metrics - Support segments
4 participants