Editorial: use leading and pending surrogate #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricea
reviewed
Apr 5, 2023
|
|
||
| <li><p><a>Prepend</a> <var>item</var> to <var>input</var>. | ||
|
|
||
| <li><p>Return U+FFFD. | ||
| </ol> | ||
|
|
||
| <li><p>If <var>item</var> is in the range U+D800 to U+DBFF, inclusive, then set <a>pending high | ||
| surrogate</a> to <var>item</var> and return <a>continue</a>. | ||
| <li><p>If <var>item</var> is a <a>leading surrogate</a>, then set <a>leading surrogate</a> to |
There was a problem hiding this comment.
I think both these <a>leading surrogate</a> will link to the same place, which seems wrong.
There was a problem hiding this comment.
Should be fixed once whatwg/infra@0dba3a2 is indexed, but I should probably use explicit for as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguably all the lead/trail byte stuff needs to be made consistent with this. Ugh.
Also, when I have more patience I should create an abstract operation for
Preview | Diff