Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define TreeNode mixin and add .closest() to more nodes #883

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Define TreeNode mixin and add .closest() to more nodes #883

wants to merge 1 commit into from

Conversation

shvaikalesh
Copy link
Contributor

@shvaikalesh shvaikalesh commented Jul 31, 2020 •
edited by pr-preview bot

Fixes #161.

I will submit a WebKit patch as soon as WPT PR is merged and synced.
Given this change adds a nice feature without growing API surface area, I have high hopes of it being landed.

(See WHATWG Working Mode: Changes for more details.)

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jan 15, 2021, 7:33 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@shvaikalesh shvaikalesh mentioned this pull request Jul 31, 2020
Open
@domenic
Copy link
Member

domenic commented Jul 31, 2020

Can you restore the pull request template, instead of deleting it?

/cc @mfreed7 to speak for Chrome's interest.

Base automatically changed from master to main January 15, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding .closest() to more nodes
2 participants
@shvaikalesh @domenic