Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a non-Korean test for Formatter #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add a non-Korean test for Formatter #7

wants to merge 3 commits into from

Conversation

lqez
Copy link
Contributor

@lqez lqez commented Oct 28, 2017

To increase the coverage a little. Also fix a warning by replacing [pytest] with [tool:pytest] in setup.cfg.

@sublee
Copy link
Contributor

sublee commented Oct 29, 2017

Please rebase it to fix the build failure.

And I suggest you separate the new assertion with a new test case such as test_formatter_without_korean.

@coveralls
Copy link

coveralls commented Oct 30, 2017 •
edited

Coverage Status

Coverage increased (+0.3%) to 99.749% when pulling f215bef on lqez:minor/more-coverage into 34b72cc on what-studio:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 99.749% when pulling f215bef on lqez:minor/more-coverage into 34b72cc on what-studio:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lqez @sublee @coveralls