Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct units for bmi calculator and weight entries #1038

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jiany18
Copy link

@jiany18 jiany18 commented May 6, 2022

Proposed Changes

  • When I was using the web app, I was really confused about which units the BMI calculator is using for weights
  • Added units to weight in BMI calculator and weight entry to avoid future confusion

@rolandgeider
Copy link
Member

Thanks for the PR! There are actually a couple of places where we do consider whether the user uses metric or imperial units, but yeah, it would be better to explicitly display the units and change them according to the profile settings. The BMI calculator actually is aware of this and will convert the values accordingly in calculate_bmi()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants