Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result page for bmi calculator & unit (kg) for Weight #1032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunx14
Copy link

@sunx14 sunx14 commented May 5, 2022

Proposed Changes

  • Add a fully functioning result page for the BMI calculator under nutrition dropdown menu so that it no longer returns just a simple HttpResposne.
  • The result page shows the BMI result and also a pie chart that shows the percentage of people with different BMI in the US.
  • Add the unit for Weight in the BMI calculator form to reduce confusion.

@rolandgeider
Copy link
Member

Thanks for the PR! The JSON response was being shown because we were using a deprecated d3 function, I've fixed that in b8d7d33 so that the chart at least updates and shows the user's BMI. What's missing is showing the different scales for the different BMIs, I'll try to look another day but since we're planing on moving some of the frontent to react to have a clean architecture, I'm not sure how much time we should invest in that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants