Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile FFMPEG missing #28

Open
DunklerPhoenix opened this issue Apr 15, 2022 · 4 comments
Open

Dockerfile FFMPEG missing #28

DunklerPhoenix opened this issue Apr 15, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@DunklerPhoenix
Copy link

In the dockerfile is ffmpeg missing and should be added for video functionality.

@rolandgeider
Copy link
Member

Hi! Adding ffmepg increases the image size by something around 400mb if I remember correctly and since this is pretty optional, I decided to leave it for the time being. Uploading should work without ffmepg, but there won't be any validation.

@DunklerPhoenix
Copy link
Author

okay. You could either create a second image with ffmpeg or you can add an option to the entrypoint script that will add ffmpeg (and additional packages which are passed by env. The second solution is for example used by photoprism. There you have a field in the config file where you can add additional packages.

@rolandgeider
Copy link
Member

Yes, we could do something like that. I'll take a look at photoprism

@DunklerPhoenix
Copy link
Author

You can set the Env (e.g.) PHOTOPRISM_INIT: "gpu, tensorflow, nano"

Here is the entry for it https://github.com/photoprism/photoprism/blob/cb89a1a189aede610d4f8c7455232d299c1a4dca/scripts/dist/entrypoint-init.sh#L68

and there are the init scripts:
https://github.com/photoprism/photoprism/tree/cb89a1a189aede610d4f8c7455232d299c1a4dca/scripts/dist

@rolandgeider rolandgeider transferred this issue from wger-project/wger May 14, 2022
@rolandgeider rolandgeider added the good first issue Good for newcomers label Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants