Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: fix warnings in portable-pty #5424

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

rgwood
Copy link
Sponsor Contributor

@rgwood rgwood commented May 15, 2024

Hi! Tiny PR, just fixes up a few build warnings when building portable-pty on Windows:

warning: the item `Path` is imported redundantly
   --> pty\src\cmdbuilder.rs:608:13
    |
9   | use std::path::{Component, Path};
    |                            ---- the item `Path` is already imported here
...
608 |         use std::path::Path;
    |             ^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

warning: function `is_cwd_relative_path` is never used
   --> pty\src\cmdbuilder.rs:749:4
    |
749 | fn is_cwd_relative_path<P: AsRef<Path>>(p: P) -> bool {
    |    ^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

I'm hoping to contribute more substantial Windows fixes soon. I've been noticing that every few days WezTerm pegs a CPU core on Windows but haven't been able to pinpoint why. I now have a build with debug symbols and I'll profile it next time the issue occurs.

@wez wez merged commit 332b9b8 into wez:main May 15, 2024
16 of 17 checks passed
@wez
Copy link
Owner

wez commented May 15, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants