feat(ssh/config): handle absolute path includes in ssh config #5184
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wez
reviewed
May 5, 2024
| @@ -175,7 +175,13 @@ impl ParsedConfigFile { | |||
| groups: &mut Vec<MatchGroup>, | |||
| loaded_files: &mut Vec<PathBuf>, | |||
| ) { | |||
| match filenamegen::Glob::new(&pattern) { | |||
| let home = dirs_next::home_dir().unwrap_or_default(); | |||
There was a problem hiding this comment.
Thanks for diving in!
- Please make the
home_dirresolution only trigger when we observe the~/prefix. - I'm not clear on why the cwd overrides the caller-supplied value for either the
~or/case; that's something that would benefit from some explanation in the code with comments. - Please add unit tests for these new cases! You can find various examples towards the bottom of this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolute path includes are currently not supported by the ssh config. For example, an Include like
Include ~/.orbstack/ssh/configwould be ignored. This PR adds support for absolute path processing while ensuring that wildcard support is still maintained.