[feature] tab min width #5035
Open
[feature] tab min width #5035
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find that after my stroke I am a bit lacking in fine motor coordination, so in both the fancy and retro tab modes the minimum tab width as is a bit small, and so am often closing tabs by accident (when no process is running, anyway) and have difficulty navigating between tabs.
This change adds a minimum tab width to both tab modes (which defaults to the previous hardcoded minimum for retro mode).
Being a bit new to rust, I haven't written any tests, but this seems to be a thing which is possibly hard to test, and
tab_max_widthseems to be untested (at least I did a bit of a search for tests usingtab_max_widthand couldn't find any, though happy to work on tests if someone can give me a bit of a pointer to how to go about it.