Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about cask and quarantine issues with MacOS #5034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshuataylor
Copy link
Sponsor

I forget about this every time. Should also help with search engines, as the error is pretty common.

Thanks MacOS 🤦

I forget about this every time. Should also help with search engines, as the error is pretty common.
homebrew/cask-versions/wezterm-nightly
wez/wezterm/wezterm-nightly
```
> 2. `--no-quarantine` is set, otherwise you will receive the warning that Wezterm cannot be opened because the developer cannot be verified. This message is from [Gatekeeper](https://support.apple.com/en-mide/102445).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I would expect here is just a warning that you downloaded something from the internet.
wezterm is signed; if are you seeing a warning that the package you are installing is not signed or not verifiable then something has gone wrong somewhere and you should not use the package.

Copy link
Sponsor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I received this when installing nightly, is nightly not signed or is that a generic warning of when you install something via the internet?

Happy to test further on a clean machine if needed. 👍

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all builds of wezterm produced by my CI on macOS are signed using my developer identity. Please share the wording from the message that you see when you don't use the quarantine option.

Copy link
Sponsor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without:

“WezTerm” is an app downloaded from the Internet. Are you sure you want to open it?

Homebrew Cask downloaded this file today at 2:24PM. Apple checked it for malicious software and none was detected.

brew uninstall --cask wezterm-nightly and then install with just that flag fixes it.

If I then do another uninstall and try without the flag, the same message appears.

I've tested this in a virtualised MacOS using tart and observe the same results.

Let me know if this makes sense..

SCR-20240219-tjnn

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise you will receive the warning that Wezterm cannot be opened because the developer cannot be verified

This wording is wrong, the developer can be verified.

I would argue that it is best to not use --no-quarantine, which would bypass other checks including unsigned binaries.

@joshuataylor
Copy link
Sponsor Author

joshuataylor commented Feb 20, 2024 via email

@wez
Copy link
Owner

wez commented Feb 21, 2024

Personally, I think it is is fine to preserve the quarantine flag and the corresponding check and prompt as the default in the documentation. It is safer for users that may not know the consequences.
Power users that feel like they know better are welcome to use it, but they are doing so at their own risk.

Since I don't personally recommend disabling those checks, I don't feel good about suggesting to do it in the docs but then telling folks not to do it in the docs, because a lot of people only skim and won't see the warning about it being a potentially dangerous thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants