nix: fix version string #4986
nix: fix version string #4986
Conversation
Derive the version string using available information. This will work well for clones of this repository, but not pure sources (e.g. GitHub source downloads). Additionally, don't override the version found in existing .tag to allow actual version to be specified manually. The side effect of this is that the actual version might differ from that of the derivation, but there are no trivial workarounds to set the derivation version based on existing .tag file given that the flakes are stored in a subdirectory instead of the root of the repository.
|
cc: @happenslol, @gabyx, @edmundmiller |
| @@ -113,7 +119,9 @@ | |||
| ''; | |||
|
|
|||
| postPatch = '' | |||
| echo ${version} > .tag | |||
| if [ ! -f .tag ]; then | |||
| echo ${version} > .tag | |||
There was a problem hiding this comment.
it's important (for my sanity) that the version number correlates with the version number that wezterm's build would have generated for the same git revision. Please share examples of what is being injected here!
There was a problem hiding this comment.
this pr aligns the version number with that of normal releases, instead of using just the first 8 characters of commit hash without date and time information. for this particular change, it continues to use whatever version is defined to (in this PR wezterm-00000000-000000-xxxxxxxx), unless there is an existing tag file which is useful for cases when the source tar is downloaded and the version cannot be reliably retrieved.
these few lines are simply bash, not nix.
Derive the version string using available information. This will work well for clones of this repository, but not pure sources (e.g. GitHub source downloads).
Additionally, don't override the version found in existing .tag to allow actual version to be specified manually. The side effect of this is that the actual version might differ from that of the derivation, but there are no trivial workarounds to set the derivation version based on existing .tag file given that the flakes are stored in a subdirectory instead of the root of the repository.