Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oasis Sapphire: update explorers #2231

Merged
merged 1 commit into from May 9, 2024
Merged

Oasis Sapphire: update explorers #2231

merged 1 commit into from May 9, 2024

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented May 8, 2024


PR-Codex overview

This PR updates the block explorer URLs for the Sapphire and Sapphire Testnet chains.

Detailed summary

  • Updated Oasis Explorer URL for Sapphire chain.
  • Updated Oasis Explorer URL for Sapphire Testnet chain.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 8, 2024

@pro-wh is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 295e108

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -13,9 +13,13 @@ export const sapphireTestnet = /*#__PURE__*/ defineChain({
},
blockExplorers: {
default: {
name: 'Oasis Explorer',
url: 'https://explorer.oasis.io/?network=testnet',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to access this explorer without the query params? This breaks the ability to use the URL and append routes to it (e.g. `${chain.blockExplors.default.url}/tx/0x...`).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I found better URLs and which don't have query params. switching to those

https://explorer.oasis.io/mainnet/sapphire
https://explorer.oasis.io/testnet/sapphire

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@tmm
Copy link
Member

tmm commented May 9, 2024

Please address comments, add a changeset, and run the formatter over the files, then re-open this PR.

@tmm tmm closed this May 9, 2024
@tmm tmm reopened this May 9, 2024
@pro-wh
Copy link
Contributor Author

pro-wh commented May 9, 2024

don't need to reopen yet, I'm still working on addressing the comments

@pro-wh
Copy link
Contributor Author

pro-wh commented May 9, 2024

  • new explorer URLs, route-append friendly
  • changeset added
  • formatter fixes

reopening

@tmm tmm merged commit e097b26 into wevm:main May 9, 2024
2 of 3 checks passed
@pro-wh
Copy link
Contributor Author

pro-wh commented May 9, 2024

thanks for the help!

@pro-wh pro-wh deleted the sapphireexplorer branch May 9, 2024 19:42
@github-actions github-actions bot mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants