New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oasis Sapphire: update explorers #2231
Conversation
@pro-wh is attempting to deploy a commit to the wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 295e108 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -13,9 +13,13 @@ export const sapphireTestnet = /*#__PURE__*/ defineChain({ | |||
}, | |||
blockExplorers: { | |||
default: { | |||
name: 'Oasis Explorer', | |||
url: 'https://explorer.oasis.io/?network=testnet', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to access this explorer without the query params? This breaks the ability to use the URL and append routes to it (e.g. `${chain.blockExplors.default.url}/tx/0x...`
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I found better URLs and which don't have query params. switching to those
https://explorer.oasis.io/mainnet/sapphire
https://explorer.oasis.io/testnet/sapphire
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Please address comments, add a changeset, and run the formatter over the files, then re-open this PR. |
don't need to reopen yet, I'm still working on addressing the comments |
reopening |
thanks for the help! |
PR-Codex overview
This PR updates the block explorer URLs for the Sapphire and Sapphire Testnet chains.
Detailed summary