fix(nelm): "werf converge" panics on first release

Signed-off-by: Ilya Lesikov <ilya@lesikov.com>
werf · Apr 4, 2024 · 4272ea6 · 4272ea6
1 parent 1b6c019
commit 4272ea6
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 9 deletions.
diff --git a/cmd/werf/bundle/apply/apply.go b/cmd/werf/bundle/apply/apply.go
@@ -491,9 +491,12 @@ func runApply(ctx context.Context) error {
 				}
 			}
 
-			releaseUpToDate, err := rlsdiff.ReleaseUpToDate(prevRelease, newRel)
-			if err != nil {
-				return fmt.Errorf("error checking if release is up to date: %w", err)
+			var releaseUpToDate bool
+			if prevReleaseFound {
+				releaseUpToDate, err = rlsdiff.ReleaseUpToDate(prevRelease, newRel)
+				if err != nil {
+					return fmt.Errorf("error checking if release is up to date: %w", err)
+				}
 			}
 
 			planUseless, err := plan.Useless()

diff --git a/cmd/werf/converge/converge.go b/cmd/werf/converge/converge.go
@@ -756,9 +756,12 @@ func run(ctx context.Context, containerBackend container_backend.ContainerBacken
 				}
 			}
 
-			releaseUpToDate, err := rlsdiff.ReleaseUpToDate(prevRelease, newRel)
-			if err != nil {
-				return fmt.Errorf("error checking if release is up to date: %w", err)
+			var releaseUpToDate bool
+			if prevReleaseFound {
+				releaseUpToDate, err = rlsdiff.ReleaseUpToDate(prevRelease, newRel)
+				if err != nil {
+					return fmt.Errorf("error checking if release is up to date: %w", err)
+				}
 			}
 
 			planUseless, err := plan.Useless()

diff --git a/cmd/werf/plan/plan.go b/cmd/werf/plan/plan.go
@@ -659,9 +659,12 @@ func run(ctx context.Context, containerBackend container_backend.ContainerBacken
 				prevRelFailed,
 			)
 
-			releaseUpToDate, err := rlsdiff.ReleaseUpToDate(prevRelease, newRel)
-			if err != nil {
-				return fmt.Errorf("error checking if release is up to date: %w", err)
+			var releaseUpToDate bool
+			if prevReleaseFound {
+				releaseUpToDate, err = rlsdiff.ReleaseUpToDate(prevRelease, newRel)
+				if err != nil {
+					return fmt.Errorf("error checking if release is up to date: %w", err)
+				}
 			}
 
 			resrcchanglog.LogPlannedChanges(