Merge pull request #4877 from werf/fix_cleanup_rare_panic_named_retur…

…n_argument fix(cleanup): rare panic related to misuse of named return argument
werf · Aug 31, 2022 · 1026317 · 1026317
2 parents f8a5dba + 9fad111
commit 1026317
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/cleaning/stage_manager/manager.go b/pkg/cleaning/stage_manager/manager.go
@@ -139,14 +139,14 @@ func (m *Manager) InitCustomTagsMetadata(ctx context.Context, storageManager man
 	return nil
 }
 
-func GetCustomTagsMetadata(ctx context.Context, storageManager manager.StorageManagerInterface) (stageIDCustomTagList map[string][]string, err error) {
+func GetCustomTagsMetadata(ctx context.Context, storageManager manager.StorageManagerInterface) (map[string][]string, error) {
 	stageCustomTagMetadataIDs, err := storageManager.GetStagesStorage().GetStageCustomTagMetadataIDs(ctx, storage.WithCache())
 	if err != nil {
 		return nil, fmt.Errorf("unable to get stage custom tag metadata IDs: %w", err)
 	}
 
 	var mutex sync.Mutex
-	stageIDCustomTagList = make(map[string][]string)
+	stageIDCustomTagList := make(map[string][]string)
 	err = storageManager.ForEachGetStageCustomTagMetadata(ctx, stageCustomTagMetadataIDs, func(ctx context.Context, metadataID string, metadata *storage.CustomTagMetadata, err error) error {
 		if err != nil {
 			return err