fix(bundles): fix werf-bundle-publish command error when --tag contai…

…ns underscore chars

Werf bundle publish command automatically generates chart.version metadata field, which equals 0.0.0-TIMESTAMP-SLUG(TAG), when TAG is not a valid semver by itself.

cmd/werf/bundle/publish/publish.go

@@ -7,6 +7,8 @@ import (
 	"path/filepath"
 	"time"
 
+	"github.com/werf/werf/pkg/slug"
+
 	"github.com/Masterminds/semver"
 
 	"helm.sh/helm/v3/pkg/getter"
@@ -370,7 +372,12 @@ func runPublish(ctx context.Context) error {
 
 	chartVersion := cmdData.Tag
 	if _, err := semver.NewVersion(chartVersion); err != nil {
-		chartVersion = fmt.Sprintf("0.0.0-%d-%s", time.Now().Unix(), chartVersion)
+		chartVersion = fmt.Sprintf("0.0.0-%d-%s", time.Now().Unix(), slug.Slug(chartVersion))
+		if _, err := semver.NewVersion(chartVersion); err != nil {
+			fallbackChartVersion := fmt.Sprintf("0.0.0-%d", time.Now().Unix())
+			logboek.Context(ctx).Warn().LogF("Unable to use %q as chart version, will fallback on chart version %q\n", chartVersion, fallbackChartVersion)
+			chartVersion = fallbackChartVersion
+		}
 	}
 
 	bundleTmpDir := filepath.Join(werf.GetServiceDir(), "tmp", "bundles", uuid.NewV4().String())

pkg/slug/slug.go

@@ -71,7 +71,7 @@ func ValidateDockerTag(name string) error {
 		return nil
 	}
 
-	return fmt.Errorf(`%q is not a valid docker tag 
+	return fmt.Errorf(`%q is not a valid docker tag
 
  - a tag name must be valid ASCII and may contain lowercase and uppercase letters, digits, underscores, periods and dashes;
  - a tag name may not start with a period or a dash and may contain a maximum of 128 characters.`, name)