Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add Certifications & Trainings Card #73

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bechir
Copy link

@bechir bechir commented Dec 21, 2020

Hi!
Thanks for this awesome project
I forked the project for my personal website but I didn't find a card for the certifications and I thought it might be interesting to add it.

I'm new to React so we have there a lot of code boilerplate.

See the README file for my progress

The JSONResume schema

@clementdevos
Copy link
Collaborator

Hi @rand0mdev
Thanks for your PR !
We'll gladly merge this if we're satisfied with it.

It's not clear wether you're done with it or not !

Do you consider your PR to be ready to review?

Cheers,

Clément

@bechir
Copy link
Author

bechir commented Dec 22, 2020

Hi @clementdevos
I still have some checklist to finish, I'll work on it this week and I will be back soon
Thanks!

@clementdevos
Copy link
Collaborator

Cool cool cool,please ping us when you're done ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants