Account for interpretations being absent #10851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4 B (0%) Total Size: 958 kB
ℹ️ View Unchanged
|
georgiaewhitney
approved these changes
May 8, 2024
|
Did they use to come back as empty arrays when undefined, maybe? |
|
from what I can tell, there are four things in a content list on the page that's breaking. Two of them are links to other pages, and two of them are events. The events have an |
|
Do we want to close this @davidpmccormick ? |
kenoir
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error we're seeing on the Schools page where events listed are expected to have an
interpretationsarray, but don't.I'm not happy that this is the final fix because it doesn't explain how this was working before (is there now interpretation data that is missing?)
But it stops the page 500ing.