use availableDates from itemsAPI with NewRequestingDayPicker #10848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +228 B (+0.02%) Total Size: 958 kB
ℹ️ View Unchanged
|
agnesgaroux
commented
May 3, 2024
| onChange={e => setChosenDate(e.target.value)} | ||
| /> | ||
| ) : ( | ||
| <>Error: Available dates could not be found.</> |
There was a problem hiding this comment.
In case there is an error in the itemsAPI when it fetches the opening times from the contentAPI, the itemsAPI returns an empty list of dates for that item, rather than than failing the entire request.
This means there is a small, yet non-null possibility that the list of available dates will be empty for one/all of the work's items. I'm choosing to wait for the last step to surface this error because it doesn't mean the item is not requestable, we just couldn't get the dates.
Is this the right way to go? and if it is, how can we make it look better? eg. add the library or digital email address?
There was a problem hiding this comment.
Does this need a designer or can we figure it out on a call tomorrow maybe?
There was a problem hiding this comment.
Copy requested from @jcateswellcome in Slack https://wellcome.slack.com/archives/C3TQSF63C/p1715246147417789
kenoir
approved these changes
May 7, 2024
rcantin-w
reviewed
May 7, 2024
rcantin-w
reviewed
May 7, 2024
rcantin-w
reviewed
May 7, 2024
There was a problem hiding this comment.
Is this wellcomecollection/content-api#126 (review) what's rendering the Error when the toggle is on ? (Just to visualise the new calendar!)
|
Seems to run nicely, I can now see the select with the dates and everything, and there doesn't seem to be unnecessary re-renders. I think my last question would just be; should I be able to see the item I requested here? (locally) 
|
|
@rcantin-w regarding the "Any item requests you make will appear here.", yes. I can see them when running locally:
|
|
New and improved look of the error message
|
gestchild
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this for?
User requesting items from closed stores to view in the reading room
What is it doing for them?
Same as before, except the dates are coming from the itemsAPI if the offsiteRequesting toggle is on
NOTE: there's a bug on the itemsAPI whereby the 1st available date is not correct. Fix coming right up
PLEASE see comment in
NewCalendarSelect