Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix privacy manifest issues #314

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix privacy manifest issues #314

merged 2 commits into from
Apr 3, 2024
+6 −15

Commits on Mar 14, 2024

  1. Fix Privacy Manifest 

    Including a NSPrivacyCollectedDataTypes entry but specifying empty strings is ... kind of invalid.

Instead, you can just specify an empty array for NSPrivacyCollectedDataTypes at the top level.

Also, the top level NSPrivacyTracking and NSPrivacyTrackingDomains keys were missing; I've added them with empty values.
    @Westacular
    Westacular committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6a2b78c View commit details
    Browse the repository at this point in the history

  2. Fix reference to privacy manifest in podspec 

    When static framework linking is used with Cocoapods, files referenced using `resource` are just directly copied into the main app bundle, potentially clobbering each other or main app resources in the process. i.e., the PrivacyInfo.xcprivacy from ZIPFoundation can overwrite the one for the app itself.

The correct way to include PrivacyInfo.xcprivacy is by using `resource_bundles` to create a nested bundle to contain the file.

(If dynamic linking is used, this bundle will be nested inside the framework bundle for the pod; if static linking is used, the bundle is nested directly in the main app bundle. In either case, clobbering is avoided.)
    @Westacular
    Westacular committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7b8b9c9 View commit details
    Browse the repository at this point in the history