Fixes so repo builds with Xcode 15 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI os(xrOS) does not work since beta 4. It should be os(visionOS). See development...osy:ZIPFoundation:development |
I don't think that's correct, I'm building one of our products using my fork and it builds, archives and uploads to App Store Connect without issues. Building on Xcode Cloud using Xcode beta 6. 🤷♂️ |
|
I’m on beta 5 so maybe it’s a recent change? Regardless Apple is sticking to visionOS as marketing and changed all their API headers to refer to visionOS. I don’t think people should refer to xrOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds the os(xrOS) conditional check, without it the build fails as it falls into the #else block.
This is required to build with Xcode 15 beta 6