Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throwing Archive Init #270

Merged
merged 32 commits into from
Sep 28, 2023
Merged

Throwing Archive Init #270

merged 32 commits into from
Sep 28, 2023

Conversation

weichsel
Copy link
Owner

@weichsel weichsel commented Feb 6, 2023

Fixes #126
Fixes #242

Changes proposed in this PR

  • Makes Archive initializers throwing
  • Adds early-exit codepath when encountering non-ZIP files

@weichsel weichsel self-assigned this Feb 6, 2023
@weichsel weichsel changed the title Enhancement/throwing archive init Throwing Archive Init Feb 7, 2023
@weichsel
Make new Archive initialize throwing and adjust first batch of test…
6008e80 
… cases
@weichsel
Throw more specific errors when making backing configurations
3ec165b
@weichsel
Replace deprecated initializer usage in ZIP64 tests
caddb24
@weichsel
Replace remaining deprecated init calls
68e161b
@weichsel
Add TODO comment
b5f5762
@weichsel
Throw more specific error when creating backing configurations
fb7bf90
@weichsel
Assert for more specific errors during testing
8591768
@weichsel
Make in-memory archive init
7d8eee3
@weichsel
Replace deprecated initializer call
812707e
@weichsel
Fix memory archive error condition test case
001f19c
@weichsel
Use test helpers to catch expected errors
e99af84
@weichsel
Fix tests on non-Darwin platforms
99958db
@weichsel
Update swift.yml with Swift versions up to 5.8
31a9e30
@weichsel
Ensure that fopen on Linux fails when executing error condition cod…
8cf83a7 
…e paths
@weichsel
Revert "Ensure that fopen on Linux fails when executing error condi…
48b32ef 
…tion code paths"

This reverts commit 8cf83a7.
@weichsel
Revert "Fix tests on non-Darwin platforms"
f181004 
This reverts commit 99958db.
@weichsel
Whitespace
8cdbcf2
@weichsel
Run test paths that expect permission errors with an unprivileged use…
4663d68 
…r to make some Linux tests pass
@weichsel
Improve test reliability on Linux
e272da8
@weichsel
Merge branch 'development' into enhancement/throwingArchiveInit
6f4dc69
@weichsel
Workaround for failing Linux tests
5f6432c
@weichsel
Use test helper instead of checking for expected error
95e0ef3
@weichsel
Adopt test helpers where possible
f6a100d
@weichsel weichsel marked this pull request as ready for review August 17, 2023 09:39
@weichsel weichsel merged commit 60626cf into development Sep 28, 2023
15 checks passed
@weichsel weichsel deleted the enhancement/throwingArchiveInit branch September 28, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@weichsel weichsel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attempting to open a non-zip file is slow Archive init should throw
1 participant
@weichsel