-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user.url_link #399
Merged
Merged
Update user.url_link #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: doublewinter0 <erdong.me@gmail.com>
Signed-off-by: doublewinter0 <erdong.me@gmail.com>
Signed-off-by: doublewinter0 <erdong.me@gmail.com>
@wj-Mcat Review 一下 |
运行 BOT 时遇到同样的报错:
目前我的解决方案是重新安装
上述问题的原因是 urllib3 在 2.0.0 版本中移除了部分弃用的 API(相关变更:urllib3/urllib3@1.26.16...2.0.0a1#diff-793e73e680de400394dedf7d080fbcef6e74c065ffcc10b8c3dc11217a786e0bL38 ),其中就包括目前 |
LGTM |
pip3 install wechaty 最新版 还是0.10.7 并没有更新到0.10.8版本 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In user.url_link.py, we use urllib3.util.url.get_host method, which is deprecated.
So I use the recommended method urllib3.util.url.parse_url instead. As a matter of fact, the deprecated method is removed in newer version.
There seems to be a small problem with the code, as follows:
The method's declared return type does not appear to match the actual return type.