Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo react native import error #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abenezermario
Copy link

node_modules/webview-crypto/src/MainWorker.ts: /../../../../node_modules/webview-crypto/src/MainWorker.ts: `import serializeError = require('serialize-error')` is not supported by @babel/plugin-transform-typescript
Please consider using `import serializeError from 'serialize-error';` alongside Typescript's --allowSyntheticDefaultImports option.
> 1 | import serializeError = require("serialize-error");
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  2 |
  3 | import {parse, stringify, ArrayBufferViewWithPromise} from "./serializeBinary";
  4 |
SyntaxError: /../../../../node_modules/webview-crypto/src/MainWorker.ts: `import serializeError = require('serialize-error')` is not supported by @babel/plugin-transform-typescript
Please consider using `import serializeError from 'serialize-error';` alongside Typescript's --allowSyntheticDefaultImports option.
> 1 | import serializeError = require("serialize-error");
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  2 |
  3 | import {parse, stringify, ArrayBufferViewWithPromise} from "./serializeBinary";
  4 |

@tyrauber
Copy link

Confirmed this resolves the typescript errors. Once this is merged and react-native-webview-crypto updated, webview-crypto can be used in Expo. Thanks @abenezermario

@jcgertig
Copy link

@LinusU any update on this?

@nitn3lav
Copy link

@saulshanabrook can you please merge this?

@saulshanabrook
Copy link
Member

@valentinleistner Thanks for the ping! Sorry I am no longer maintaining this library.

If anyone else wants to merge this in and make a release, please reply with your NPM username and I will add you to the package.

@abenezermario
Copy link
Author

NPM username: abenezermario

@saulshanabrook
Copy link
Member

@abenezermario Added! You should be able to merge and publish the package.

@amark
Copy link

amark commented Aug 6, 2022

Oh wow @abenezermario, saving the day! :)

@abenezermario
Copy link
Author

Thank you 🙏 @amark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants