Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use failure_message/failure_message_when_negated rspec matchers #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use failure_message/failure_message_when_negated rspec matchers #370

wants to merge 1 commit into from

Conversation

mzahir
Copy link

@mzahir mzahir commented Sep 18, 2015

Gets rid of the deprecation warnings

`failure_message_for_should_not` is deprecated. Use `failure_message_when_negated` instead. 
Called from ~/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/websocket-rails-0.7.0/lib/spec_helpers/matchers/route_matchers.rb:37:in `block in <top (required)>'.

`failure_message_for_should` is deprecated. Use `failure_message` instead.
 Called from ~/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/websocket-rails-0.7.0/lib/spec_helpers/matchers/route_matchers.rb:33:in `block in <top (required)>'.

@recurser
Copy link

👍 I was about to submit a PR for the same thing

@recurser
Copy link

recurser commented Nov 9, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants