Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed in Access-Control-Allow-Origin for standalone mode #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samuelnp
Copy link

I tried to make a connection in rails project, from 127.0.0.1:3000 to 127.0.0.1:3001 in standalone mode and request.raw_host_with_port returns ip address with same port from standalone server. This behavior breaks connection from client using XHR. Furthermore, in my pull request i have added the possibility to add more than one domain in configuration array.

Regards

@g3d
Copy link

g3d commented Jan 29, 2015

Can you update specs to fix travis build?

@samuelnp
Copy link
Author

Hi g3d

Travis fails because there is a problem with phantom.js. Specs are ok if you see Travis CI details.

Finished in 1.99 seconds
262 examples, 0 failures

Here is the error

Phantomjs does not appear to be installed in /home/travis/.phantomjs/1.9.7/x86_64-linux/bin/phantomjs, installing!
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 14134 100 14134 0 0 40291 0 --:--:-- --:--:-- --:--:-- 72112
bunzip2: phantomjs-1.9.7-linux-x86_64.tar.bz2 is not a bzip2 file.
tar: phantomjs-1.9.7-linux-x86_64.tar: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
rake aborted!
can't convert nil into String
/home/travis/build/websocket-rails/websocket-rails/vendor/bundle/ruby/1.9.1/gems/phantomjs-1.9.7.0/lib/phantomjs/platform.rb:72:in block in install!' /home/travis/build/websocket-rails/websocket-rails/vendor/bundle/ruby/1.9.1/gems/phantomjs-1.9.7.0/lib/phantomjs/platform.rb:53:inchdir'
/home/travis/build/websocket-rails/websocket-rails/vendor/bundle/ruby/1.9.1/gems/phantomjs-1.9.7.0/lib/phantomjs/platform.rb:53:in install!' /home/travis/build/websocket-rails/websocket-rails/vendor/bundle/ruby/1.9.1/gems/phantomjs-1.9.7.0/lib/phantomjs/platform.rb:86:inensure_installed!'
/home/travis/build/websocket-rails/websocket-rails/vendor/bundle/ruby/1.9.1/gems/phantomjs-1.9.7.0/lib/phantomjs.rb:30:in platform' /home/travis/build/websocket-rails/websocket-rails/vendor/bundle/ruby/1.9.1/gems/phantomjs-1.9.7.0/lib/phantomjs.rb:25:inpath'
/home/travis/build/websocket-rails/websocket-rails/vendor/bundle/ruby/1.9.1/gems/jasmine-2.0.0/lib/jasmine/runners/phantom_js.rb:13:in run' /home/travis/build/websocket-rails/websocket-rails/vendor/bundle/ruby/1.9.1/gems/jasmine-2.0.0/lib/jasmine/tasks/jasmine.rake:49:inblock (2 levels) in <top (required)>'
/home/travis/build/websocket-rails/websocket-rails/Rakefile:69:in block (3 levels) in <top (required)>' /home/travis/build/websocket-rails/websocket-rails/Rakefile:41:inblock in <top (required)>'
Tasks: TOP => jasmine:ci
(See full trace by running task with --trace)

@dakariakin
Copy link

Only rspec specs are ok, i think
Besides them there are jasmine specs that didn't start
And i have the same problem with Phantomjs on ubuntu 14.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants