GetDisplayMedia: add Start/Stop switch #1616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepancar
reviewed
Oct 4, 2023
| if (displaySurface !== 'default') { | ||
| options.video = {displaySurface}; | ||
| startStopButton.addEventListener('click', () => { | ||
| if (startStopButton.textContent === 'Start') { |
There was a problem hiding this comment.
textContent is a state of dom. Wouldn't it be better make this decision based on explicitly defined boolean variable?
There was a problem hiding this comment.
💯
added a displayMediaStarted boolean
…reen sharing started in order to demonstrate stopping screen share from javascript
eronnen
force-pushed
the
add-getdisplaymedia-sample-stop-javascript
branch
from
9c02ebd
to
00c3b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a stop button to the
getdisplaymediademoPurpose