feature: allow embed <replay-web-page> to also support updating favicons from replay #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons from the replay - enabled via 'updateFavicons' attribute - pass icons via postMessage() update, adding type to embed message to allow different types of message - currently supporting 'urlchange' and 'favicons' - add shared updateFaviconLinks(), used by both embed and main app
emma-sg
force-pushed
the
embed-update-favicons
branch
from
5abc675
to
97df2d5
Compare
…n creating a `new URLSearchParams`
emma-sg
approved these changes
Mar 8, 2024
…luding url, ts, view and query only specific values as part of hashtag only include view in hashtag if no url is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be useful to be able to have embed also take over the favicons for the page, propagating them from the replay (eg. if in a single page app where replay takes up most of the view).
This PR adds a
updateFaviconsattribute, used as<replay-web-page ... updateFavicons>to have icons propagated from the replay to the top-level frame. (This may be especially useful withdeepLinkoption, which allows for linking directly to archived pages)Details:
Testing:
The top-level page favicons should get updated with icons from the replay