Typescript config parity with Browsertrix repo (#289)

Follow-up from #288 

This matches the strictness rules with the Browsertrix repo,
specifically `noImplicitAny`, and then adds `// @ts-expect-error`s to
suppress existing errors this change raises. This'll help us keep code
quality high moving forward.

Going to just directly merge this once it passes CI; as with #288, this
doesn't change any code, just comments.

src/appmain.ts

@@ -480,6 +480,7 @@ export class ReplayWebApp extends LitElement {
     }
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   onFavIcons(event) {
     const head = document.querySelector("head")!;
     const oldLinks = document.querySelectorAll("link[rel*='icon']");
@@ -496,13 +497,15 @@ export class ReplayWebApp extends LitElement {
     }
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   skipMenu(event) {
     // This is a workaround, since this app's routing doesn't permit normal
     // following of in-page anchors.
     event.preventDefault();
     this.renderRoot.querySelector<HTMLElement>("#skip-main-target")?.focus();
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   onNavMenu(event) {
     event.preventDefault();
     event.stopPropagation();
@@ -644,6 +647,7 @@ export class ReplayWebApp extends LitElement {
     }
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   onStartLoad(event) {
     // just redirect right away?
     // TODO: Fix this the next time the file is edited.
@@ -665,6 +669,7 @@ export class ReplayWebApp extends LitElement {
     this.loadInfo = event.detail;
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   onCollLoaded(event) {
     this.loadInfo = null;
     if (event.detail.collInfo) {
@@ -687,6 +692,7 @@ export class ReplayWebApp extends LitElement {
     }
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   onTitle(event) {
     if (event.detail.title) {
       this.pageTitle = event.detail.title;

src/chooser.ts

@@ -77,6 +77,7 @@ export class Chooser extends LitElement {
     }
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   onChooseFile(event) {
     if (event.currentTarget.files.length === 0) {
       return;
@@ -167,6 +168,7 @@ export class Chooser extends LitElement {
     return false;
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   onInput(event) {
     this.fileDisplayName = event.currentTarget.value;
 
@@ -255,7 +257,10 @@ export class Chooser extends LitElement {
               ${!this.hasNativeFS
                 ? html` <input
                     class="file-input"
-                    @click="${(e) => (e.currentTarget.value = null)}"
+                    @click="${
+                      // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'e' implicitly has an 'any' type.
+                      (e) => (e.currentTarget.value = null)
+                    }"
                     @change=${this.onChooseFile}
                     type="file"
                     id="fileupload"

src/electron-preload.ts

@@ -1,5 +1,6 @@
 /*eslint-env node */
 
+// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7016 - Could not find a declaration file for module '@webrecorder/wabac/src/loaders'. 'node_modules/@webrecorder/wabac/src/loaders.js' implicitly has an 'any' type.
 import { CollectionLoader } from "@webrecorder/wabac/src/loaders";
 import { type IpcRendererEvent } from "electron";
 
@@ -12,11 +13,15 @@ const dbs = {};
 const loader = new CollectionLoader();
 
 async function getColl(name: string) {
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7053 - Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{}'.
   if (!dbs[name]) {
+    // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7053 - Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{}'.
     dbs[name] = await loader.loadColl(name);
+    // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7053 - Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{}'.
     await dbs[name].initing;
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7053 - Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{}'.
   // TODO: Fix this the next time the file is edited.
   // eslint-disable-next-line @typescript-eslint/no-unsafe-return
   return dbs[name];

src/electron-replay-app.ts

@@ -16,13 +16,15 @@ import {
 import path from "path";
 import fs from "fs";
 
+// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7016 - Could not find a declaration file for module '@webrecorder/wabac/src/rewrite'. 'node_modules/@webrecorder/wabac/src/rewrite/index.js' implicitly has an 'any' type.
 import { ArchiveResponse, Rewriter } from "@webrecorder/wabac/src/rewrite";
 
 import { PassThrough, Readable } from "stream";
 
 import { autoUpdater } from "electron-updater";
 import log from "electron-log";
 
+// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7016 - Could not find a declaration file for module 'mime-types'. 'node_modules/mime-types/index.js' implicitly has an 'any' type.
 import mime from "mime-types";
 import url from "url";
 
@@ -214,6 +216,7 @@ class ElectronReplayApp {
     this.mainWindow = this.createMainWindow(process.argv);
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'request' implicitly has an 'any' type. | TS7006 - Parameter 'callback' implicitly has an 'any' type.
   async doHandleFile(request, callback) {
     //const parsedUrl = new URL(request.url);
     //const filename = parsedUrl.searchParams.get("filename");
@@ -259,6 +262,7 @@ class ElectronReplayApp {
     }
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'data' implicitly has an 'any' type.
   _bufferToStream(data) {
     const rv = new PassThrough();
     rv.push(data);
@@ -267,6 +271,7 @@ class ElectronReplayApp {
   }
 
   async doIntercept(
+    // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'request' implicitly has an 'any' type.
     request,
     callback: (response: {
       statusCode: number;
@@ -337,6 +342,7 @@ class ElectronReplayApp {
     await this.proxyLive(request, callback);
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'request' implicitly has an 'any' type. | TS7006 - Parameter 'callback' implicitly has an 'any' type.
   async proxyLive(request, callback) {
     let headers = request.headers;
     const { method, url, uploadData } = request;
@@ -364,8 +370,6 @@ class ElectronReplayApp {
     const data = method === "HEAD" ? null : response.body;
     const statusCode = response.status;
 
-    // TODO: Fix this the next time the file is edited.
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     headers = Object.fromEntries(response.headers.entries());
     callback({ statusCode, headers, data });
   }
@@ -379,6 +383,7 @@ class ElectronReplayApp {
    *    data: unknown;
    * }) => void} callback
    */
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'url' implicitly has an 'any' type. | TS7006 - Parameter 'callback' implicitly has an 'any' type.
   notFound(url, callback) {
     console.log("not found: " + url);
     const data = this._bufferToStream(
@@ -391,6 +396,7 @@ class ElectronReplayApp {
     });
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'request' implicitly has an 'any' type. | TS7006 - Parameter 'callback' implicitly has an 'any' type.
   async resolveArchiveResponse(request, callback) {
     const channel = `req:${new Date().getTime()}:${request.url}`;
 
@@ -469,6 +475,7 @@ class ElectronReplayApp {
     }
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'reqHeaders' implicitly has an 'any' type. | TS7006 - Parameter 'headers' implicitly has an 'any' type. | TS7006 - Parameter 'size' implicitly has an 'any' type.
   parseRange(reqHeaders, headers, size) {
     let statusCode = 200;
     const range = reqHeaders.get("range");
@@ -495,6 +502,7 @@ class ElectronReplayApp {
     return { statusCode, start, end };
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'argv' implicitly has an 'any' type.
   createMainWindow(argv) {
     const sourceString = this.getOpenUrl(argv);
 
@@ -521,6 +529,7 @@ class ElectronReplayApp {
     return theWindow;
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'argv' implicitly has an 'any' type.
   getOpenUrl(argv) {
     argv = require("minimist")(argv.slice(process.defaultApp ? 2 : 1));
 
@@ -565,6 +574,7 @@ class ElectronReplayApp {
   }
 }
 
+// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'body' implicitly has an 'any' type. | TS7006 - Parameter 'session' implicitly has an 'any' type.
 async function* readBody(body, session) {
   for (const chunk of body) {
     if (chunk.bytes) {

src/embed-receipt.ts

@@ -357,6 +357,7 @@ export class RWPEmbedReceipt extends LitElement {
     `;
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   onEmbedDrop(event) {
     event.stopPropagation();
     this.active = !this.active;

src/embed.ts

@@ -24,7 +24,9 @@ class Embed extends LitElement {
   @property({ type: String }) ts = "";
   @property({ type: String }) query = "";
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7008 - Member 'source' implicitly has an 'any' type.
   @property({ type: String }) source;
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7008 - Member 'src' implicitly has an 'any' type.
   @property({ type: String }) src;
 
   @property({ type: String }) view = "replay";
@@ -57,6 +59,7 @@ class Embed extends LitElement {
     | string
     | undefined;
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7008 - Member 'requireSubdomainIframe' implicitly has an 'any' type.
   @property({ type: Boolean }) requireSubdomainIframe;
 
   @property({ type: String }) loading = "";
@@ -73,6 +76,7 @@ class Embed extends LitElement {
   isCrossOrigin: boolean | undefined;
   swmanager: SWManager | undefined;
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'replayfile' implicitly has an 'any' type.
   static setDefaultReplayFile(replayfile) {
     defaultReplayFile = replayfile;
   }
@@ -109,6 +113,7 @@ class Embed extends LitElement {
     }
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   handleMessage(event) {
     const iframe = this.renderRoot.querySelector("iframe");
 
@@ -353,6 +358,7 @@ class Embed extends LitElement {
     `;
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   onLoad(event) {
     if (this.isCrossOrigin) {
       return;

src/gdrive.ts

@@ -97,6 +97,7 @@ class GDrive extends LitElement {
 
   onLoad() {
     this.scriptLoaded = true;
+    // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'response' implicitly has an 'any' type.
     this.gauth("none", (response) => {
       if (response.error) {
         if (this.state !== "implicitonly") {
@@ -111,6 +112,7 @@ class GDrive extends LitElement {
   }
 
   onClickAuth() {
+    // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'response' implicitly has an 'any' type.
     this.gauth("select_account", (response) => {
       if (!response.error) {
         // TODO: Fix this the next time the file is edited.
@@ -120,6 +122,7 @@ class GDrive extends LitElement {
     });
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'response' implicitly has an 'any' type.
   async authed(response) {
     const sourceUrl = this.sourceUrl;
     const fileId = sourceUrl.slice("googledrive://".length);
@@ -200,6 +203,7 @@ class GDrive extends LitElement {
     return script;
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'prompt' implicitly has an 'any' type. | TS7006 - Parameter 'callback' implicitly has an 'any' type.
   gauth(prompt, callback) {
     self.gapi.load("auth2", () => {
       self.gapi.auth2.authorize(

src/item-index.ts

@@ -120,6 +120,7 @@ class ItemIndex extends LitElement {
     }
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
   async onDeleteItem(event) {
     event.preventDefault();
     event.stopPropagation();

src/item-info.ts

@@ -240,6 +240,7 @@ class ItemInfo extends LitElement {
     return false;
   }
 
+  // @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'reload' implicitly has an 'any' type.
   onPurge(reload) {
     const detail = { reload };
     this.dispatchEvent(new CustomEvent("item-purge", { detail }));