Email config options #229
Draft
Email config options #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavares843
reviewed
May 11, 2023
There was a problem hiding this comment.
One minor nitpick is that the comparison for the smtp_starttls environment variable should be case-insensitive, as the value is converted to lowercase before the comparison.
Another minor suggestion is to add some documentation to explain the new environment variables and their purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roughly inspired by how Airflow does things: https://airflow.apache.org/docs/apache-airflow/stable/howto/email-config.html#using-default-smtp
This PR adds some more options to allow TLS to be switched off, allow connection to SMTP without logging in, and to make use of the specified port number.
Creating as a draft because: