[Bug] Collection detail: only update dialog state on close event if close event originates from dialog #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
approved these changes
May 9, 2024
emma-sg
commented
May 13, 2024
Comment on lines
-179
to
+180
| label=${msg("Delete Collection?")} | ||
| ?open=${this.openDialogName === "delete"} | ||
| .label=${msg("Delete Collection?")} | ||
| .open=${this.openDialogName === "delete"} |
There was a problem hiding this comment.
Just changed these cause my editor was raising warnings about them, I know it doesn't change any functionality
emma-sg
deleted the
frontend-fix-collection-share-dialog-closing-on-tooltip-close
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1553
Changes
Adds a check on
sl-hideevents to ensure that only the events originating from the elements we want to listen to are acted on