Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow QA view to be larger than viewport height if necessary #1790

Merged
merged 8 commits into from
May 14, 2024

Conversation

emma-sg
Copy link
Member

@emma-sg emma-sg commented May 8, 2024

Closes #1789

Changes

  • Converts stylesheet in js to css now that it doesn't use any runtime values
  • Removes fixed height on QA container, and instead sets a min height
  • Applies contain: size to page list & tab content so they don't cause the QA container to stretch
  • Also updates instances of h-{n} w-{n} to size-{n}
  • Removes leftover outlines on text and resource comparison areas from early QA prototyping

@emma-sg emma-sg added bug Something isn't working front end Requires front end dev work labels May 8, 2024
@emma-sg emma-sg requested a review from SuaYoo May 8, 2024 02:11
@emma-sg emma-sg self-assigned this May 8, 2024
@SuaYoo
Copy link
Collaborator

SuaYoo commented May 13, 2024

@emma-sg I can look into the scroll snap issue here after the merge conflict is fixed, and if this is rebased?

@emma-sg
Copy link
Member Author

emma-sg commented May 13, 2024

@SuaYoo I think I fixed it in the merge! It only applies on large viewports now (where the layout is split into cols)

@emma-sg emma-sg merged commit d6f2fee into main May 14, 2024
2 checks passed
@emma-sg emma-sg deleted the frontend-qa-image-comparison-layout-fix branch May 14, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front end Requires front end dev work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA fast-follow: improve qa scrolling content layouts
2 participants