Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend queue offset #1581

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Frontend queue offset #1581

wants to merge 7 commits into from

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Mar 6, 2024 •
edited

Resolves #1580

Changes

Enables users to jump to a URL position in the crawl queue.

Manual testing

  1. Log in as crawler and start a crawl with more than 50 pages.
  2. Go to watch crawl. Verify "Queued URLs from [1] to of " is shown under "Upcoming Pages".
  3. Enter number into input. Verify input cannot be less than 1 or more than total - 50, and that list updates as expected.
  4. Scroll to load more. Verify list updates as expected, and input number updates if more than the list total.

Screenshots

Page Image/video
Workflow Detail - Watch Screenshot 2024-03-06 at 9 23 43 AM
Workflow Detail - Exclusion Editor Screenshot 2024-03-06 at 9 23 50 AM
Workflow Detail - Exclusion Editor Screenshot 2024-03-06 at 9 24 01 AM

@ikreymer ikreymer changed the base branch from main to v1.9.3-work March 6, 2024 07:13
@ikreymer
Copy link
Member

ikreymer commented Mar 6, 2024 •
edited

Tested locally, looks good, working both on the detail page and in the exclusion editor.

@ikreymer
Copy link
Member

ikreymer commented Mar 6, 2024

Ah, found one issue, when at the end of the queue, the ... still appears, and just allows extending the page end indefinitely, instead of showing End of Queue:
Screenshot 2024-03-05 at 11 42 55 PM

@SuaYoo SuaYoo marked this pull request as ready for review March 6, 2024 17:35
@ikreymer
Copy link
Member

ikreymer commented Mar 6, 2024

When a queue is growing, sometimes entering the offset resets it back to lower value even though queue is now longer.

Base automatically changed from v1.9.3-work to main March 6, 2024 23:38
@SuaYoo SuaYoo marked this pull request as draft March 11, 2024 23:26
@SuaYoo SuaYoo marked this pull request as ready for review May 7, 2024 21:25
emma-sg
emma-sg approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the extra console.log, looks good!

frontend/src/components/utils/observable.ts
@@ -31,7 +31,9 @@ export class Observable extends LitElement {
}

disconnectedCallback(): void {
console.log("disconnect?");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this out, unless you want to debug it in prod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emma-sg emma-sg emma-sg approved these changes

@ikreymer ikreymer Awaiting requested review from ikreymer

@Shrinks99 Shrinks99 Awaiting requested review from Shrinks99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow entering queue offset for crawler queue
3 participants
@SuaYoo @ikreymer @emma-sg