Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Activating tooltips on the collection share dialog closes the dialog #1553

Closed
Shrinks99 opened this issue Feb 27, 2024 · 1 comment · Fixed by #1579 or #1793
Closed

[Bug]: Activating tooltips on the collection share dialog closes the dialog #1553

Shrinks99 opened this issue Feb 27, 2024 · 1 comment · Fixed by #1579 or #1793
Assignees
@emma-sg
Labels
bug Something isn't working front end Requires front end dev work
Milestone
v1.9.3

Comments

@Shrinks99
Copy link
Member

Browsertrix Cloud Version

v1.10.0-beta.0-1493278

What did you expect to happen? What happened instead?

When hovering over any of the tooltips on the collection share dialog, the dialog gets closed without any further input from the user

Step-by-step reproduction instructions

  1. Open the collection share dialog
  2. Hover over an icon button
  3. Exit hover such that the tooltip should go away
  4. The whole dialog goes away!

Additional details

Screen.Recording.2024-02-27.at.1.00.55.AM.mov
@Shrinks99 Shrinks99 added bug Something isn't working front end Requires front end dev work labels Feb 27, 2024
@Shrinks99 Shrinks99 added this to the v1.9.3 milestone Mar 4, 2024
@SuaYoo SuaYoo mentioned this issue Mar 6, 2024
Merged
@SuaYoo SuaYoo self-assigned this Mar 6, 2024
ikreymer pushed a commit that referenced this issue Mar 6, 2024
@SuaYoo
Prevent closing tooltips from closing collecction share dialog (#1579)
5287678 
Fixes #1553
@ikreymer ikreymer closed this as completed Mar 6, 2024
ikreymer pushed a commit that referenced this issue Mar 6, 2024
@SuaYoo @ikreymer
Prevent closing tooltips from closing collecction share dialog (#1579)
04b081e 
Fixes #1553
ikreymer pushed a commit that referenced this issue Mar 6, 2024
@SuaYoo @ikreymer
Prevent closing tooltips from closing collecction share dialog (#1579)
69a4f63 
Fixes #1553
@Shrinks99
Copy link
Member Author

This appears to still be happening with the share link visit tooltip but not the copy one in v1.10.0-beta.6-e7dbf91.

Looking back at the PR, it seems we only fixed this for the copy button... Missed when reviewing :(

@Shrinks99 Shrinks99 reopened this May 7, 2024
@emma-sg emma-sg assigned emma-sg and unassigned SuaYoo May 8, 2024
@emma-sg emma-sg mentioned this issue May 8, 2024
Merged
emma-sg added a commit that referenced this issue May 14, 2024
@emma-sg
[Bug] Collection detail: only update dialog state on close event if c…
76cd19d 
…lose event originates from dialog (#1793)

Closes #1553

## Changes
Adds a check on `sl-hide` events to ensure that only the events
originating from the elements we want to listen to are acted on
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emma-sg emma-sg

Labels
bug Something isn't working front end Requires front end dev work
Projects
Webrecorder Projects
Status: Done!
Milestone
v1.9.3
4 participants
@ikreymer @SuaYoo @Shrinks99 @emma-sg