Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA fast-follow: improve qa scrolling content layouts #1789

Closed
emma-sg opened this issue May 8, 2024 · 0 comments · Fixed by #1790
Closed

QA fast-follow: improve qa scrolling content layouts #1789

emma-sg opened this issue May 8, 2024 · 0 comments · Fixed by #1790
Assignees
@emma-sg
Labels
bug Something isn't working front end Requires front end dev work
Milestone
v1.10.0

Comments

@emma-sg
Copy link
Member

emma-sg commented May 8, 2024

Tracked in #1756
@emma-sg emma-sg added bug Something isn't working front end Requires front end dev work labels May 8, 2024
@emma-sg emma-sg added this to the v1.10.0 milestone May 8, 2024
@emma-sg emma-sg self-assigned this May 8, 2024
This was referenced May 8, 2024
Merged
Closed
@emma-sg emma-sg changed the title QA fast-follow: [bugfix] Image comparer is cut off in smaller app heights QA fast-follow: improve qa scrolling content layouts May 8, 2024
emma-sg added a commit that referenced this issue May 14, 2024
@emma-sg
Allow QA view to be larger than viewport height if necessary (#1790)
d6f2fee 
Closes #1789

### Changes
- Converts stylesheet in js to css now that it doesn't use any runtime
values
- Removes fixed height on QA container, and instead sets a min height
- Applies `contain: size` to page list & tab content so they don't cause
the QA container to stretch
- Also updates instances of `h-{n} w-{n}` to `size-{n}`
- Removes leftover outlines on text and resource comparison areas from
early QA prototyping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emma-sg emma-sg

Labels
bug Something isn't working front end Requires front end dev work
Projects
Webrecorder Projects
Status: Done!
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

Allow QA view to be larger than viewport height if necessary webrecorder/browsertrix
1 participant
@emma-sg