Skip to content

Commit

Permalink
Make storage deletion work on more S3 providers, don't use access URL…
Browse files Browse the repository at this point in the history
… for deletion (#1600)

I came across [this
problem](https://forum.webrecorder.net/t/deleting-crawl-failure/512) and
noticed that the access URL is used when deleting files, causing my file
deletions to fail on OpenStack SWIFT S3 (relates to #1090). This trivial
change makes it work there.
  • Loading branch information
wvengen committed Mar 16, 2024
1 parent eb7036b commit 6278157
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion backend/btrixcloud/storages.py
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ async def _delete_file(

s3storage = self.get_org_storage_by_ref(org, storage)

async with self.get_s3_client(s3storage, s3storage.use_access_for_presign) as (
async with self.get_s3_client(s3storage) as (
client,
bucket,
key,
Expand Down

0 comments on commit 6278157

Please sign in to comment.