Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from 1.0.3 release -> main #517

Merged
merged 5 commits into from Mar 26, 2024
Merged

Fixes from 1.0.3 release -> main #517

merged 5 commits into from Mar 26, 2024

Conversation

ikreymer
Copy link
Member

sitemap improvements: gz support + application/xml + extraHops fix #511

  • follow up to Implement more efficient sitemap parsing. #496
  • support parsing sitemap urls that end in .gz with gzip decompression
  • support both application/xml and text/xml as valid sitemap
    content-types (add test for both)
  • ignore extraHops for sitemap found URLs by setting to past extraHops
    limit (otherwise, all sitemap URLs would be treated as links from seed
    page)

fixes redirected seed (from #476) being counted against page limit: #509

  • subtract extraSeeds when computing limit
  • don't include redirect seeds in seen list when serializing
  • tests: adjust saved-state-test to also check total pages when crawl is
    done

fixes #508

ikreymer and others added 5 commits March 26, 2024 11:21
)

- subtract extraSeeds when computing limit
- don't include redirect seeds in seen list when serializing
- tests: adjust saved-state-test to also check total pages when crawl is
done

fixes #508
(for 1.0.3 release)
)

sitemap fixes,  follow up to #496
- support parsing sitemap urls that end in .gz with gzip decompression
- support both `application/xml` and `text/xml` as valid sitemap
content-types (add test for both)
- ignore extraHops for sitemap found URLs by setting to past extraHops
limit (otherwise, all sitemap URLs would be treated as links from seed
page)
@ikreymer ikreymer merged commit 01c4139 into main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seed redirect causes one less URL to be crawled due to limit
1 participant