Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade puppeteer-core to 22.6.1 #516

Merged
merged 4 commits into from Mar 27, 2024
Merged

upgrade puppeteer-core to 22.6.1 #516

merged 4 commits into from Mar 27, 2024

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Mar 26, 2024

Using latest puppeteer-core to keep up with latest browsers, mostly minor syntax changes

Due to change in puppeteer hiding the executionContextId, need to create a frameId->executionContextId mapping and track it ourselves to support the custom evaluateWithCLI() function

@ikreymer ikreymer requested a review from tw4l March 26, 2024 16:46
add frameIdToExecId mapping in browser, listen to exec context created, destroyed, cleared events
@ikreymer ikreymer merged commit 0d973d6 into main Mar 27, 2024
4 checks passed
@ikreymer ikreymer deleted the upgrade-puppeteer branch March 27, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants