service worker capture fix: disable by default for now #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- due to issues with capturing top-level pages, add option to disabled service workers always - add --serviceWorker option which can be disable, disable-if-profile (previous default) and enabled - ensure page ts is set for direct fetch - warn if page ts is missing, then set to now before serializing bump to 1.0.2
tw4l
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Works great! Tested with https://bitarchivist.net, and now seeing the full request/response records in the WARCs and timestamps for all files!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to issues with capturing top-level pages, make bypassing service workers the default for now. Previously, it was only disabled when using profiles. (This is also consistent with ArchiveWeb.page behavior).
Includes:
disabled, disabled-if-profile (previous default) andenabledbump version to 1.0.2