improvements to 'non-graceful' interrupt to ensure WARCs are still closed gracefully #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osed gracefully: - immediately exit the browser, and call closeWorkers() - finalize() recorder, finish active WARC records but don't fetch anything else - flush() existing open writer, mark as done, don't write anything else
ikreymer
commented
Mar 21, 2024
ikreymer
commented
Mar 21, 2024
ikreymer
commented
Mar 21, 2024
ikreymer
commented
Mar 21, 2024
ikreymer
commented
Mar 21, 2024
tw4l
approved these changes
Mar 21, 2024
ikreymer
commented
Mar 21, 2024
tw4l
reviewed
Mar 21, 2024
tw4l
reviewed
Mar 21, 2024
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is for even non-graceful interruption (duplicate Ctrl+C) to still result in valid WARC records, even if page is unfinished:
This should work with multiple SIGINT/SIGTERM signals. Sending a SIGKILL / docker kill .. will result in immediate exit and may still result in invalid WARC records, as the crawler is interrupted immediately.