SAX-based sitemap parser #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better error handling
continue fetching sitemaps async include nsted sitemaps queued count in logging store if sitemap parsing was finished in redis, include in save/load, don't reparse if fully parsed
…mit is hit. when at limit, don't report any errors, close xml stream and pass end event to the root
|
Proper review coming, but in the meantime, this might also be a nice time to add a section on sitemap parsing to the crawler docs (happy to push that myself). |
tw4l
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Nicely done! Left a few nitpicky comments, but I've tested this now on a good number of sitemaps, including some sitemap indices/nested sitemaps, and it's working great!
I pushed a commit with a docs update. Once we get some tests here, I think it's good to go :)
ends in /robots.txt, parse as text
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
if just --sitemap/--useSitemap given, then - first try parsing <seed>/robots.txt - then try parsing <seed>/sitemap.xml if sitemap url specified, then: - fetch and detect content type, and parse as either xml or robots.txt based on extension and content-type
… and specific URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new SAX-based sitemap parser, inspired by: https://www.npmjs.com/package/sitemap-stream-parser
Supports:
fromandtofilter dates, to only include URLs between the given datespageLimit, don't add URLs pass the page limit, interrupt further parsing when at limit.Fixes #496
TODO: Still need tests