Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MKDocs documentation site for Browsertrix Crawler 1.0.0 #494

Merged
merged 37 commits into from Mar 16, 2024
Merged

Conversation

tw4l
Copy link
Contributor

@tw4l tw4l commented Mar 13, 2024

Fixes #493

This PR updates the documentation for Browsertrix Crawler 1.0.0 and moves it from the project README to an MKDocs site.

TODO:

To try the docs locally (after installing mkdocs-material via pip in a virtual env or similar):

cd docs && mkdocs serve

Many thanks to @Shrinks99 for help setting this up!

image

@tw4l tw4l requested review from ikreymer and Shrinks99 March 13, 2024 19:47
@Shrinks99
Copy link
Member

Shrinks99 commented Mar 13, 2024

RE domain: Eventually as part of a large site refresh I'd like the docs to be all under our domain so that search engines crawl the whole thing and understand it as one large website. This will also simplify the navigation of all tools (and their documentation) developed under the Webrecorder brand.

If not under a subdomain (maybe the best option for now, simplifies things) something like webrecorder.net/docs/browsertrix-crawler ?? We'd also have webrecorder.net/docs/archive-webpage for example.

EDIT: See chat for further discussion. It's lookin like subdomains!

Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the categories! Site looks great. :D

The cli-options page is probably fine for now, though I'd want to break these out to other pages — presumably people come to the docs because that text didn't help them!

Have noted below, but pretty sure insertversion.js should be removed. I've made a whooooole bunch of copy edits as suggestions.

Once these fixes are in, good to go from me!

docs/docs/index.md Outdated Show resolved Hide resolved
docs/docs/index.md Outdated Show resolved Hide resolved
docs/docs/index.md Outdated Show resolved Hide resolved
docs/docs/index.md Outdated Show resolved Hide resolved
docs/docs/js/insertversion.js Outdated Show resolved Hide resolved
docs/docs/user-guide/crawl-scope.md Outdated Show resolved Hide resolved
docs/docs/user-guide/yaml-config.md Outdated Show resolved Hide resolved
docs/docs/user-guide/yaml-config.md Outdated Show resolved Hide resolved
docs/docs/user-guide/yaml-config.md Outdated Show resolved Hide resolved
docs/docs/user-guide/yaml-config.md Outdated Show resolved Hide resolved
@tw4l
Copy link
Contributor Author

tw4l commented Mar 14, 2024

Thanks @Shrinks99 ! Suggestions applied and much appreciated :)

The cli-options page is probably fine for now, though I'd want to break these out to other pages — presumably people come to the docs because that text didn't help them!

Yeah, there's definitely opportunity to improve and expand the docs moving forward, though I think it is sometimes useful as a reference (I've consulted this list in the existing README a few times because it's easier to read in a place like this than in a console).

@tw4l tw4l requested a review from Shrinks99 March 14, 2024 15:46
Further clarifies extra hops language
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed two more small fixes. Looks great! Happy to see this information moved out of the monolithic readme file!

@tw4l
Copy link
Contributor Author

tw4l commented Mar 15, 2024

It looks like we now have two CNAME files, one in the root directory for the crawler and another in docs/docs. I assume we only want the latter? Not changing at this point because I'm not sure what URL we settled on for the docs.

@ikreymer ikreymer merged commit e1fe028 into main Mar 16, 2024
4 checks passed
@ikreymer ikreymer deleted the docs-1.0.0 branch March 16, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation for 1.0.0
3 participants