Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on status code option + requeue fix #480

Merged
merged 1 commit into from Mar 5, 2024

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Mar 4, 2024

Add fail on status code option, --failOnInvalidStatus to treat non-200 responses as failures. Can be useful especially when combined with --failOnFailedSeed or --failOnFailedLimit

requeue: ensure requeued urls are requeued with same depth/priority, not 0

…es, especially when combined with --failOnFailedSeed or --failOnFailedLimit

requeue: ensure requeued urls are requeued with same depth/priority, not 0
@ikreymer ikreymer requested a review from tw4l March 4, 2024 19:01
Copy link
Contributor

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial reaction was to not want to add another arg required to make --failOnFailedSeed work, but after thinking about it a moment, what you have here is nice and flexible.

@ikreymer ikreymer merged commit 4520e9e into dev-1.0.0 Mar 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants