Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes "recording" from verbage #165

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Removes "recording" from verbage #165

merged 11 commits into from
Nov 16, 2023

Conversation

Shrinks99
Copy link
Member

@Shrinks99 Shrinks99 commented Jul 1, 2023 •
edited

Closes #163

  • Replaces "recording" with "archiving" when referring to the action of collecting content from the web
  • Replaces "archive" with "archived item" and "archiving session" when referring to the object
  • Removes ellipses on button rollover text
  • Other minor copy changes

Testing

Visit every page in the app, read the copy, and ensure it makes sense and is consistent?

@Shrinks99
Removes "recording" from verbage
90b3d81 
Replaces with "archiving"
@Shrinks99 Shrinks99 requested a review from ikreymer July 1, 2023 01:14
@Shrinks99 Shrinks99 marked this pull request as draft July 4, 2023 02:35
@Shrinks99 Shrinks99 marked this pull request as ready for review July 26, 2023 20:33
@Shrinks99 Shrinks99 requested a review from SuaYoo July 26, 2023 20:33
@Shrinks99
Replaces Web Captures with Archived Items
91acf3e 
- Replaces relevant other terms with "Archiving Session"
@Shrinks99 Shrinks99 requested a review from tw4l November 15, 2023 21:46
tw4l
tw4l reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and questions, overall looks nice! Tested from a local build.

src/ui/app.js Outdated Show resolved Hide resolved
src/ui/app.js Outdated Show resolved Hide resolved
src/ui/app.js Outdated Show resolved Hide resolved
src/ui/coll-info.js Outdated Show resolved Hide resolved
src/ui/coll-info.js Outdated Show resolved Hide resolved
src/ui/coll-info.js Outdated Show resolved Hide resolved
src/ui/app.js Show resolved Hide resolved
src/ui/app.js Outdated Show resolved Hide resolved
Shrinks99 and others added 6 commits November 15, 2023 18:58
@Shrinks99 @tw4l
Update src/ui/app.js
4a55d7f 
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
@Shrinks99 @tw4l
Update src/ui/app.js
92868aa 
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
@Shrinks99 @tw4l
Update src/ui/coll-info.js
9cc9f48 
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
@Shrinks99 @tw4l
Update src/ui/coll-info.js
02ebee3 
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
@Shrinks99 @tw4l
Update src/ui/coll-info.js
d223c87 
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
@Shrinks99 @tw4l
Update src/ui/app.js
ecd30a4 
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Shrinks99
Shrinks99 commented Nov 16, 2023
View reviewed changes
src/ui/app.js Outdated Show resolved Hide resolved
@Shrinks99
Copy link
Member Author

With Tessa's suggestions and approval I think we can finally put this one to bed! Any future issues should be able to be dealt with on a case-by-case basis. :)

@Shrinks99 Shrinks99 merged commit 5431064 into main Nov 16, 2023
3 checks passed
@Shrinks99 Shrinks99 deleted the frontend-strip-recording-language branch November 16, 2023 03:49
@Shrinks99 Shrinks99 mentioned this pull request Apr 12, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

@ikreymer ikreymer Awaiting requested review from ikreymer

@SuaYoo SuaYoo Awaiting requested review from SuaYoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "record" from verbage
2 participants
@Shrinks99 @tw4l