Skip to content

Commit

Permalink
fix remaining issues preventing build
Browse files Browse the repository at this point in the history
  • Loading branch information
emma-sg committed Jan 24, 2024
1 parent c0c8f49 commit b3be837
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 25 deletions.
2 changes: 1 addition & 1 deletion src/electron/rec-window.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
css,
wrapCss,
clickOnSpacebarPress,
} from "replaywebpage/dist/misc";
} from "replaywebpage/src/misc";

import fasRefresh from "@fortawesome/fontawesome-free/svgs/solid/redo-alt.svg";
//import fasFullscreen from '@fortawesome/fontawesome-free/svgs/solid/desktop.svg';
Expand Down
20 changes: 8 additions & 12 deletions src/ui/app.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import { ifDefined } from "lit/directives/if-defined.js";

import { html, css, wrapCss, IS_APP, apiPrefix } from "replaywebpage/dist/misc";
import { html, css, wrapCss, IS_APP, apiPrefix } from "replaywebpage/src/misc";

// replaywebpage imports
import { ReplayWebApp, Embed, Loader } from "replaywebpage";
Expand Down Expand Up @@ -498,11 +496,9 @@ class ArchiveWebApp extends ReplayWebApp {
this.embed || this.showDownloadProgress ? 0 : 10
}
.shareOpts=${{ ipfsOpts: this.ipfsOpts, btrixOpts: this.btrixOpts }}
swName=${ifDefined(this.swName)}
embed="${ifDefined(this.embed === null ? undefined : this.embed)}"
sourceUrl="${ifDefined(
this.sourceUrl === null ? undefined : this.sourceUrl
)}"
.swName=${this.swName ?? null}
.embed="${this.embed}"
.sourceUrl="${this.sourceUrl}"
appName="${this.appName}"
appVersion=${VERSION}
@replay-favicons=${this.onFavIcons}
Expand Down Expand Up @@ -994,7 +990,7 @@ class ArchiveWebApp extends ReplayWebApp {
type="url"
name="btrixUrl"
id="btrixUrl"
value="${this.btrixOpts && this.btrixOpts.url}"
value="${this.btrixOpts?.url || ""}"
placeholder="https://..."
/>
</p>
Expand All @@ -1007,7 +1003,7 @@ class ArchiveWebApp extends ReplayWebApp {
type="text"
name="btrixUsername"
id="btrixUsername"
value="${this.btrixOpts && this.btrixOpts.username}"
value="${this.btrixOpts?.username || ""}"
placeholder="Username"
/>
</p>
Expand All @@ -1020,7 +1016,7 @@ class ArchiveWebApp extends ReplayWebApp {
type="password"
name="btrixPassword"
id="btrixPassword"
value="${this.btrixOpts && this.btrixOpts.password}"
value="${this.btrixOpts?.password || ""}"
placeholder="Password"
/>
</p>
Expand All @@ -1033,7 +1029,7 @@ class ArchiveWebApp extends ReplayWebApp {
type="text"
name="btrixOrgName"
id="btrixOrgName"
value="${this.btrixOpts && this.btrixOpts.orgName}"
value="${this.btrixOpts?.orgName || ""}"
placeholder="Organization (optional)"
/>
</p>
Expand Down
5 changes: 2 additions & 3 deletions src/ui/coll-index.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { ItemIndex } from "replaywebpage";
import type { PropertyValues } from "lit";
import { property } from "lit/decorators.js";
import { ifDefined } from "lit/directives/if-defined.js";

import { html } from "replaywebpage/dist/misc";
import { html } from "replaywebpage/src/misc";

import prettyBytes from "pretty-bytes";
import { type WrRecCollInfo } from "./coll-info";
Expand Down Expand Up @@ -65,7 +64,7 @@ class WrRecCollIndex extends ItemIndex {
renderItemInfo(item: WrRecItem) {
return html` <wr-rec-coll-info
style="overflow: visible"
data-coll="${ifDefined(item.id)}"
data-coll="${item.id!}"
.item=${item}
.shareOpts=${this.shareOpts}
@ipfs-share="${this.onIpfsShare}"
Expand Down
2 changes: 1 addition & 1 deletion src/ui/coll-info.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { html, css, wrapCss, apiPrefix } from "replaywebpage/dist/misc";
import { html, css, wrapCss, apiPrefix } from "replaywebpage/src/misc";

import prettyBytes from "pretty-bytes";

Expand Down
11 changes: 5 additions & 6 deletions src/ui/coll.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ import {
wrapCss,
clickOnSpacebarPress,
apiPrefix,
} from "replaywebpage/dist/misc";
} from "replaywebpage/src/misc";

import fasDownload from "@fortawesome/fontawesome-free/svgs/solid/download.svg";

import prettyBytes from "pretty-bytes";

import { Coll } from "replaywebpage";
import { Item } from "replaywebpage";
import wrRec from "../../assets/recLogo.svg";

//============================================================================
class WrRecColl extends Coll {
class WrRecColl extends Item {
constructor() {
super();
// @ts-expect-error - TS2551 - Property '_sizeUpdater' does not exist on type 'WrRecColl'. Did you mean 'runSizeUpdater'?
Expand All @@ -25,7 +25,7 @@ class WrRecColl extends Coll {

static get properties() {
return {
...Coll.properties,
...Item.properties,

totalSize: { type: Number },
shareOpts: { type: Object },
Expand Down Expand Up @@ -54,7 +54,7 @@ class WrRecColl extends Coll {
font-weight: bold;
}
${Coll.compStyles}
${Item.compStyles}
`;
}

Expand Down Expand Up @@ -89,7 +89,6 @@ class WrRecColl extends Coll {
}
}

// @ts-expect-error - TS2416 - Property 'renderExtraToolbar' in type 'WrRecColl' is not assignable to the same property in base type 'Item'.
renderExtraToolbar(isDropdown = false) {
if (this.embed) {
if (!isDropdown) {
Expand Down
2 changes: 1 addition & 1 deletion src/ui/upload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
wrapCss,
apiPrefix,
LitElement,
} from "replaywebpage/dist/misc";
} from "replaywebpage/src/misc";
import prettyBytes from "pretty-bytes";

import fasSync from "@fortawesome/fontawesome-free/svgs/solid/sync-alt.svg";
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7642,7 +7642,7 @@ repeat-string@^1.6.1:

"replaywebpage@git+https://github.com/webrecorder/replayweb.page.git#emma/publish-generated-types":
version "2.0.0-beta"
resolved "git+https://github.com/webrecorder/replayweb.page.git#7a7232896e98c6f7a6c98ce85b76f1667cc527bd"
resolved "git+https://github.com/webrecorder/replayweb.page.git#d4db282c78407d7e248c9a3bc2953a3b40c101ee"
dependencies:
"@fortawesome/fontawesome-free" "^5.15.4"
"@shoelace-style/shoelace" "^2.8.0"
Expand Down

0 comments on commit b3be837

Please sign in to comment.